gpecf-set-discount-amount-by-field-value.php: Fixed an issue with comma values in discount calculations.
#926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omma values in discount calculations.
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
Suggestion to use existing GF JS function
gp-ecommerce-fields/gpecf-set-discount-amount-by-field-value.php
Outdated
Show resolved
Hide resolved
…omma values in discount calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2768471028/74224
Summary
When using the snippet along with a calculated Number field, if the number is greater than 1000, and so includes a comma, only the digits in front of the comma are being copied to the Discount field.
BEFORE:
AFTER:
